From 5bdead249ee5628c8c24482c2667f861c7de5201 Mon Sep 17 00:00:00 2001
From: zefie <zefie@zefie.net>
Date: Sun, 9 Oct 2022 17:25:42 -0400
Subject: [PATCH] more favorites fixes

---
 .../ServiceVault/wtv-favorite/add.js          |   2 +-
 .../ServiceVault/wtv-favorite/favorite.js     | 352 ------------------
 2 files changed, 1 insertion(+), 353 deletions(-)

diff --git a/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/add.js b/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/add.js
index cdd4beb4..7ae5064b 100644
--- a/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/add.js
+++ b/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/add.js
@@ -75,7 +75,7 @@ async function saveFavorite(favstore, title, folder, imagetype, favurl) {
 		if (!favstore.folderExists(folder)) {
 			// user did not define a folder, and the default folder does not exist
 			// so choose the user's first available folder
-			var favfolders = favstore.listFolders();
+			var favfolders = favstore.getFolders();
 			if (favfolders.length > 0) folder = favfolders[0];
 		}
 		if (!folder) {
diff --git a/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/favorite.js b/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/favorite.js
index d61ce8bb..feadfbb1 100644
--- a/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/favorite.js
+++ b/zefie_wtvp_minisrv/ServiceVault/wtv-favorite/favorite.js
@@ -253,358 +253,6 @@ for ${session_data.getSessionData("subscriber_username") || "You"}
 		}
 	}
 
-	/*
-if (totalfavorites > 2)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[2]}">
-<font size="-1">
-<limittext value="${folder_array[2]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 2) {
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 4)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[4]}">
-<font size="-1">
-<limittext value="${folder_array[4]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 4) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 6)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[6]}">
-<font size="-1">
-<limittext value="${folder_array[6]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 6) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 8)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[8]}">
-<font size="-1">
-<limittext value="${folder_array[8]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 8) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 10)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[10]}">
-<font size="-1">
-<limittext value="${folder_array[10]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 10) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 12)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[12]}">
-<font size="-1">
-<limittext value="${folder_array[12]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 12) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-}
-
-if (totalfavorites == 14) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/LeftBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="40" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 1)
-{
-	data += `<tr><td><table cellspacing="0" cellpadding="0">
-<tbody><tr><td width="6" height="12"><img src="wtv-home:/ROMCache/Spacer.gif" width="1" height="1">
-</td><td width="20">
-</td></tr></tbody></table>
-</tr><td></td></tr></tbody></table>
-</td><td valign="top" align="left">
-<table width="225" cellspacing="0" cellpadding="0">
-<tbody><tr><td absheight="21" bgcolor="2b2b2b"> 
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightTop.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[1]}">
-<font size="-1">
-<limittext value="${folder_array[1]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 1) {
-	data += `<tr><td><table cellspacing="0" cellpadding="0">
-<tbody><tr><td width="6" height="12"><img src="wtv-home:/ROMCache/Spacer.gif" width="1" height="1">
-</td><td width="20">
-</td></tr></tbody></table>
-</tr><td></td></tr></tbody></table>
-</td><td valign="top" align="left">
-<table width="225" cellspacing="0" cellpadding="0">
-<tbody><tr><td absheight="20" bgcolor="2b2b2b"> 
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightTopEdgeOnly.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 3)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[3]}">
-<font size="-1">
-<limittext value="${folder_array[3]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 3) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 5)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[5]}">
-<font size="-1">
-<limittext value="${folder_array[5]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 5) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 7)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[7]}">
-<font size="-1">
-<limittext value="${folder_array[7]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 7) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 9)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[9]}">
-<font size="-1">
-<limittext value="${folder_array[9]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 9) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 11)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[11]}">
-<font size="-1">
-<limittext value="${folder_array[11]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 11) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-if (totalfavorites > 13)
-{
-	data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightMiddle.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-<a href="wtv-favorite:/serve-browser?favorite_folder_name=${folder_array[13]}">
-<font size="-1">
-<limittext value="${folder_array[13]}" width="140"></limittext></font></a><font size="-1">
-</font>
-</td><td width="20">
-</td></tr></tbody></table>`
-} else if (totalfavorites == 13) {
-		data += `
-</td></tr><tr><td width="225" valign="middle" height="42" background="ROMCache/RightBottom.gif" align="center">
-<table width="50%" cellspacing="0" cellpadding="0">
-<tbody><tr><td width="5" height="20">
-</td><td maxlines="1" width="140" height="20" align="center">
-</td><td width="20">
-</td></tr></tbody></table>`
-
-stopdrawing = true;
-
-}
-*/
 	data += `
 </td></tr></tbody></table>
 </td></tr></tbody></table>