zefie/minisrv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v0.9.3

Browse Source 
- fix: wtv-home:/home: remove `nostatus` to enable loading progress bar for outgoing links

- fix: wtv-1800:/finish-prereg: swap error message location for better debugging

- fix: app.js: Properly clean up old sockets
This commit is contained in:
zefie
2021-07-21 23:18:33 -04:00
parent a67ad6b43c
commit 45bbcecb72
4 changed files with 24 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zefie_wtvp_minisrv/ServiceVault/wtv-1800/finish-prereg.js
View File

@@ -5,7 +5,8 @@ if (socket.ssid != null) {
ssid_sessions[socket.ssid].data_store.wtvsec_login.set_incarnation(request_headers["wtv-incarnation"]); ssid_sessions[socket.ssid].data_store.wtvsec_login.set_incarnation(request_headers["wtv-incarnation"]);
} }
} else { } else {
var errpage = doErrorCode(400); console.log(" * Something bad happened (we don't know the client ssid???)");
var errpage = doErrorCode(400)
headers = errpage[0]; headers = errpage[0];
data = errpage[1]; data = errpage[1];
} }
@@ -63,8 +64,7 @@ wtv-client-date: `+ strftime("%a, %d %b %Y %H:%M:%S", new Date(new Date().toUTCS
}); });
} }
} else { } else {
console.log(" * Something bad happened (we don't know the client ssid???)"); var errpage = doErrorCode(400);
var errpage = doErrorCode(400)
headers = errpage[0]; headers = errpage[0];
data = errpage[1]; data = errpage[1];
} }

2
zefie_wtvp_minisrv/ServiceVault/wtv-home/home.js
View File

@@ -14,7 +14,7 @@ if (ssid_sessions[socket.ssid].get('box-does-psuedo-encryption')) {
data =`<html> data =`<html>
<head> <head>
<title>Home for minisrv</title> <title>Home for minisrv</title>
<DISPLAY NoLogo NoStatus hideoptions noscroll> <DISPLAY NoLogo hideoptions noscroll>
</head> </head>
<body bgcolor="black" link="gold" vlink="gold" alink="gold" text="gold"> <body bgcolor="black" link="gold" vlink="gold" alink="gold" text="gold">
<script> <script>

28
zefie_wtvp_minisrv/app.js
View File

@@ -596,9 +596,9 @@ async function processRequest(socket, data_hex, returnHeadersBeforeSecure = fals
socket.ssid = headers["wtv-client-serial-number"]; socket.ssid = headers["wtv-client-serial-number"];
if (!ssid_sessions[socket.ssid]) { if (!ssid_sessions[socket.ssid]) {
ssid_sessions[socket.ssid] = new ClientSessionData(); ssid_sessions[socket.ssid] = new ClientSessionData();
ssid_sessions[socket.ssid].sockets = new Array();
ssid_sessions[socket.ssid].sockets.push(socket.id);
} }
if (!ssid_sessions[socket.ssid].data_store.sockets) ssid_sessions[socket.ssid].data_store.sockets = new Array();
ssid_sessions[socket.ssid].data_store.sockets.push(socket.id);
} }
@@ -751,18 +751,19 @@ async function checkForPostData(socket, headers, data, data_hex) {
async function cleanupSocket(socket) { async function cleanupSocket(socket) {
try { try {
if (!zquiet) console.log(" * Destroying old WTVSec instance on disconnected socket", socket.id); if (socket_sessions[socket.id]) {
delete socket_sessions[socket.id].buffer; if (!zquiet) console.log(" * Cleaning up disconnected socket", socket.id);
delete socket_sessions[socket.id].wtvsec;
delete socket_sessions[socket.id]; delete socket_sessions[socket.id];
if (socket.ssid) {
if (ssid_sessions[socket.ssid].sockets.findIndex(element => element = socket.id) != -1) {
ssid_sessions[socket.ssid].sockets.splice(ssid_sessions[socket.ssid].sockets.findIndex(element => element = socket.id));
} }
var fuckyou = ssid_sessions[socket.ssid].sockets; if (socket.ssid) {
if (ssid_sessions[socket.ssid].sockets.length === 0 && ssid_sessions[socket.ssid].get("wtvsec_login")) { var socket_array_index = ssid_sessions[socket.ssid].data_store.sockets.findIndex(element => element = socket.id);
if (socket_array_index != -1) {
ssid_sessions[socket.ssid].data_store.sockets.splice(socket_array_index,1);
}
if (ssid_sessions[socket.ssid].data_store.sockets.length === 0 && ssid_sessions[socket.ssid].data_store.wtvsec_login) {
// if last socket for SSID disconnected, destroy login session // if last socket for SSID disconnected, destroy login session
if (!zquiet) console.log(" * Last socket from WebTV SSID", filterSSID(socket.ssid),"disconnected, destroying initial WTVSec instance"); if (!zquiet) console.log(" * Last socket from WebTV SSID", filterSSID(socket.ssid),"disconnected, cleaning up primary WTVSec instance for this SSID");
ssid_sessions[socket.ssid].delete("wtvsec_login"); ssid_sessions[socket.ssid].delete("wtvsec_login");
} }
} }
@@ -814,6 +815,11 @@ async function handleSocket(socket) {
// Attempt to clean up all of our WTVSec instances // Attempt to clean up all of our WTVSec instances
cleanupSocket(socket); cleanupSocket(socket);
}); });
socket.on('close', function () {
// Attempt to clean up all of our WTVSec instances
cleanupSocket(socket);
});
} }
function integrateConfig(main, user) { function integrateConfig(main, user) {

2
zefie_wtvp_minisrv/package.json
View File

@@ -1,6 +1,6 @@
{ {
"name": "zefie_wtvp_minisrv", "name": "zefie_wtvp_minisrv",
"version": "0.9.2", "version": "0.9.3",
"description": "WebTV Service (WTVP) Emulation Server", "description": "WebTV Service (WTVP) Emulation Server",
"main": "app.js", "main": "app.js",
"homepage": "https://github.com/zefie/zefie_wtvp_minisrv", "homepage": "https://github.com/zefie/zefie_wtvp_minisrv",