From 20357809a7e8afa456365fe857d57de2bed2e91e Mon Sep 17 00:00:00 2001
From: zefie <zefie@zefie.net>
Date: Thu, 30 Apr 2026 02:15:58 -0400
Subject: [PATCH] move 'hide_minisrv_version' from services to config

---
 zefie_wtvp_minisrv/app.js               | 6 +++---
 zefie_wtvp_minisrv/includes/config.json | 6 ++----
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/zefie_wtvp_minisrv/app.js b/zefie_wtvp_minisrv/app.js
index 0da6b9e2..2ec431fd 100644
--- a/zefie_wtvp_minisrv/app.js
+++ b/zefie_wtvp_minisrv/app.js
@@ -495,7 +495,7 @@ async function handleCGI(executable, cgi_file, socket, request_headers, vault, s
     env.SERVER_PORT = request_data.port;
     env.SERVER_ADDR = request_data.host;
     env.SERVER_NAME = request_data.host;
-    if ((minisrv_config.services[socket.service_name] && minisrv_config.services[socket.service_name].hide_minisrv_version) || minisrv_config.config.hide_server_version) {
+    if (minisrv_config.config.hide_minisrv_version) {
         env.SERVER_SOFTWARE = "NodeJS; minisrv";
     } else {
         // Full version
@@ -1592,7 +1592,7 @@ async function sendToClient(socket, headers_obj, data = null, throttle = 0) {
     if (!xpower && socket.service_name) {
         // add X-Powered-By header if not WebTV and not already set
         xpower = 'X-Powered-By';
-        if (minisrv_config.services[socket.service_name].hide_minisrv_version) {   
+        if (minisrv_config.config.hide_minisrv_version) {   
             // Don't report version         
             if (!socket.ssid) headers_obj[xpower] = "NodeJS; minisrv";
         } else {
@@ -1603,7 +1603,7 @@ async function sendToClient(socket, headers_obj, data = null, throttle = 0) {
         // delete if webtv
         if (socket.ssid) delete headers_obj[xpower];
         if (socket.service_name) {
-            if (minisrv_config.services[socket.service_name].hide_minisrv_version) {   
+            if (minisrv_config.config.hide_minisrv_version) {   
                 // Don't report version         
                 if (!socket.ssid) headers_obj[xpower] = headers_obj[xpower] + "; NodeJS; minisrv";
             } else {
diff --git a/zefie_wtvp_minisrv/includes/config.json b/zefie_wtvp_minisrv/includes/config.json
index 9d10dcae..f7b03d8a 100644
--- a/zefie_wtvp_minisrv/includes/config.json
+++ b/zefie_wtvp_minisrv/includes/config.json
@@ -41,7 +41,7 @@
     "post_data_socket_timeout": 30, // How long until we give up waiting for data from the client in a POST transfer. Too little and POSTs will fail when dialup retrains. Too much and the server may stall waiting.
     "error_log_file": "errors.log", // Where to write errors to disk
     "catchall_file_name": "catchall.js", // default catchall filename
-    "hide_incomplete_features": true, // this is barely used and being phase out. leave it unchanged.
+    "hide_minisrv_version": true, // hide or show the minisrv version (eg like Apache version, can be hidden to hide known exploits for older version)
     "enable_lzpf_compression": true, // Toggle LZPF (old classic) compression. Best left unchanged.
     "enable_gzip_compression": true, // Toggle GZIP (all other boxes) compression. Best left unchanged.
     "show_detailed_splash": true, // Shows the service name, server version, and user connect speed on the splash page
@@ -435,8 +435,7 @@
     "pb_services": {
       // PC Services for PageBuilder
       "port": 1697,
-      "pc_services": true, // defines service as a PC service
-      "hide_minisrv_version": true, // hide or show the minisrv version (eg like Apache version, can be hidden to hide known exploits for older version)
+      "pc_services": true, // defines service as a PC service      
       "servicevault_dir": "http_pb", // The service vault dir for the PC Services for PageBuilder
       "service_vaults": [ "PageBuilderVault" ], // additional service vaults for this service
       "drop_connection_on_wrong_port": true, // If true, resets connection if the PC browser connects to a port that is not PC Services enabled
@@ -455,7 +454,6 @@
       // PC Services
       "port": 1699,
       "pc_services": true, // defines service as a PC service
-      "hide_minisrv_version": true, // hide or show the minisrv version (eg like Apache version, can be hidden to hide known exploits for older version)
       "disabled": true, // disabled by default, set disabled: false in user_config.json for this service to enable.
       "servicevault_dir": "http_pc", // The service vault dir for the PC Services
       "drop_connection_on_wrong_port": false, // If true, resets connection if the PC browser connects to a port that is not PC Services enabled