v0.9.33

- numerous bug fixes
 - wtv-mail system
 - user account updates
 - viewergen alpha (experimental webtv viewer patcher on pc_service)
 - implement wtv-favorites with huge help from @JarHead4
 - add wtv-ticket store api
 - Bump vm2 from 3.9.5 to 3.9.7 in /zefie_wtvp_minisrv
 - fix bf0app default rom
 - Add wtv-1800 service to wtv-1800:/noflash
 - handle webtvism:
   - allow get/post variables to be the same name multiple times
   - rather than overwrite, the server will now change the variable from a string to an array.
 - Rewrite script processing a bit
   - Instead of using eval() we now use a proper VM Context
   - As a result, any scripting errors will now give a more useful filename and line number.
   - However, some things may break, if they are dependant on variables we are not allowing in the context.
 - BREAKING CHANGES:
   - `ssid_sessions[socket.ssid]` is now `session_data`
   - `require` is no longer allowed in user scripts
 - add star service
 - change how we handle modules for services in the VM
 - fixed wtv-disk:/sync always failed the first time
 - implement production-like wtv-star handling (when a service port becomes unavailable, it requests the url over the wtv-star port to show an error page)
 - renamed WTVDownloadList.js to WTVDisk.js
 - a bit more work on WTVNews (created class)
 - probably more stuff I can't remember

zefie_wtvp_minisrv/ServiceVault/wtv-setup/validate-add-user-done.js

@@ -0,0 +1,67 @@
+var minisrv_service_file = true;
+var userSession = null;
+var errpage = null;
+
+if (session_data.user_id != 0) errpage = wtvshared.doErrorPage(400, "You are not authorized to add users to this account.");
+
+// seperate if statements as to not overwrite the first error if multiple occur
+
+if (!errpage) {
+    if (request_headers.query.user_password) {
+        if (request_headers.query.user_password.length < minisrv_config.config.passwords.min_length) errpage = wtvshared.doErrorPage(400, "Your password must contain at least " + minisrv_config.config.passwords.min_length + " characters.");
+        else if (request_headers.query.user_password.length > minisrv_config.config.passwords.max_length) errpage = wtvshared.doErrorPage(400, "Your password must contain no more than than " + minisrv_config.config.passwords.max_length + " characters.");
+        else if (request_headers.query.user_password !== request_headers.query.user_password2) errpage = wtvshared.doErrorPage(400, "The passwords you entered did not match. Please check them and try again.");
+    }
+    else if (!request_headers.query.user_name) errpage = wtvshared.doErrorPage(400, "Please enter a username.");
+}
+
+if (!errpage) {
+    if (session_data.getNumberOfUserAccounts() > minisrv_config.config.user_accounts.max_users_per_account) errpage = wtvshared.doErrorPage(400, "You are not authorized to add more than " + minisrv_config.config.user_accounts.max_users_per_account + ` account${minisrv_config.config.user_accounts.max_users_per_account > 1 ? 's' : ''}.`);
+}
+
+if (errpage) {
+    headers = errpage[0];
+    data = errpage[1];
+} else {
+    if (!request_headers.query.display_name) request_headers.query.display_name = request_headers.query.username;
+    userSession = new WTVClientSessionData(minisrv_config, socket.ssid);
+    var freeUserId = session_data.findFreeUserSlot(session_data);
+    if (freeUserId) {
+        userSession.user_id = freeUserId;
+        userSession.setSessionData("subscriber_userid", freeUserId);
+        userSession.setSessionData("subscriber_name", request_headers.query.display_name);
+        userSession.setSessionData("subscriber_username", request_headers.query.user_name);
+        userSession.setSessionData("registered", true);
+        var mailstore_exists = userSession.mailstore.mailstoreExists();
+        var mailbox_exists = false;
+        if (!mailstore_exists) mailstore_exists = userSession.mailstore.createMailstore();
+        if (mailstore_exists) {
+            if (!userSession.mailstore.mailboxExists(0)) {
+                // mailbox does not yet exist, create it
+                mailbox_exists = userSession.mailstore.createMailbox(0);
+            }
+            if (mailbox_exists) {
+                // Just created Inbox for the first time, so create the welcome message
+                userSession.mailstore.createWelcomeMessage();
+            }
+        }
+        if (!userSession.saveSessionData(true, true)) {
+            var errpage = wtvshared.doErrorPage(400);
+            headers = errpage[0];
+            data = errpage[1];
+        } else {
+            if (request_headers.query.user_password) {
+                userSession.setUserPassword(request_headers.query.user_password);
+                userSession.setUserLoggedIn(true);
+            }
+            
+
+            headers = `300 OK
+Content-type: text/html
+wtv-expire: wtv-setup:/accounts
+Location: wtv-setup:/accounts`;
+        }
+    }    
+}
+
+if (userSession) userSession = null;